Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotly Visualizer Widget For DeepForge. Fixes #1308, #1290 #1329

Merged
merged 23 commits into from
Nov 27, 2019

Conversation

umesh-timalsina
Copy link
Contributor

This PR adds subplot support (#1290) to the metamodel, as well as create a visualizer using plotly.js to convert display the subplot (#1308), with this merged, incremental Image Support (#1218) can be done.

@umesh-timalsina umesh-timalsina marked this pull request as ready for review November 22, 2019 00:13
@umesh-timalsina
Copy link
Contributor Author

This PR is ready for review, deepforge will now officially support subplots.

src/plugins/ExecuteJob/ExecuteJob.Metadata.js Outdated Show resolved Hide resolved
src/seeds/pipeline/version.txt Outdated Show resolved Hide resolved
src/common/viz/PlotlyDescExtractor.js Show resolved Hide resolved
src/common/viz/PlotlyDescExtractor.js Show resolved Hide resolved
src/common/viz/PlotlyDescExtractor.js Outdated Show resolved Hide resolved
2. Major Update to the pipeline seed, which is now 0.14.0
3. Remove All the var keywords with let/const
4. Check isEmpty without spread operator in plotlyGraphWidget.js, change plotlyJSON to directly be stored as an object
5. Remove Displayed Executions spread operator in ExecutionIndexControl.js
6. Remove widget calls from consolidateGraphData in ExecutionIndexControl.js
7. Remove extrabookkeeping in ExecutionIndexControl
8. Add function called setDisplayName to add default title with execution Abbr in ExecutionIndexControl
9. Refactor _updateGraphData to _updateGraphWidget, _widget methods are called from there in ExecutionIndexControl.js Now.
10. setDisplayedExections in ExecutionIndexWidget now updates the displayedExecutions added or removed.
11. Couple of other minor changes
…ange displayedExecutions to an array in ExecutionIndex, change variable name in PlotlyGraphWidget from plotsData to plotlyJSON
Copy link
Contributor

@brollb brollb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is coming along nicely! A couple little things and then we should hopefully be all set!

src/plugins/ExecuteJob/ExecuteJob.Metadata.js Outdated Show resolved Hide resolved
src/plugins/ExecuteJob/ExecuteJob.Metadata.js Outdated Show resolved Hide resolved
src/plugins/ExecuteJob/ExecuteJob.Metadata.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants