-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotly Visualizer Widget For DeepForge. Fixes #1308, #1290 #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es according to newer metamodel in ExecuteJob.metadata.js
…ges to clone graph desc
…data, Refactor GraphDescExtractor to send plotlyJSON Directly to widget (Widget Display problem for Failed execcutions)
This PR is ready for review, deepforge will now officially support subplots. |
brollb
requested changes
Nov 25, 2019
2. Major Update to the pipeline seed, which is now 0.14.0 3. Remove All the var keywords with let/const 4. Check isEmpty without spread operator in plotlyGraphWidget.js, change plotlyJSON to directly be stored as an object 5. Remove Displayed Executions spread operator in ExecutionIndexControl.js 6. Remove widget calls from consolidateGraphData in ExecutionIndexControl.js 7. Remove extrabookkeeping in ExecutionIndexControl 8. Add function called setDisplayName to add default title with execution Abbr in ExecutionIndexControl 9. Refactor _updateGraphData to _updateGraphWidget, _widget methods are called from there in ExecutionIndexControl.js Now. 10. setDisplayedExections in ExecutionIndexWidget now updates the displayedExecutions added or removed. 11. Couple of other minor changes
…ange displayedExecutions to an array in ExecutionIndex, change variable name in PlotlyGraphWidget from plotsData to plotlyJSON
brollb
requested changes
Nov 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is coming along nicely! A couple little things and then we should hopefully be all set!
brollb
reviewed
Nov 26, 2019
brollb
approved these changes
Nov 27, 2019
This was referenced Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds subplot support (#1290) to the metamodel, as well as create a visualizer using
plotly.js
to convert display the subplot (#1308), with this merged, incremental Image Support (#1218) can be done.